[master] a3ff92588 Eliminate racy and surplus to requirements subtest.

Poul-Henning Kamp phk at FreeBSD.org
Tue Oct 12 15:55:07 UTC 2021


commit a3ff9258861e3d523bf5105a66f33e5b869a4a06
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Tue Oct 12 15:53:48 2021 +0000

    Eliminate racy and surplus to requirements subtest.

diff --git a/bin/varnishtest/tests/b00037.vtc b/bin/varnishtest/tests/b00037.vtc
index 74fad6118..63d8014dc 100644
--- a/bin/varnishtest/tests/b00037.vtc
+++ b/bin/varnishtest/tests/b00037.vtc
@@ -1,6 +1,7 @@
 varnishtest "Error on multiple Host headers"
 
 varnish v1 -vcl {backend be none;} -start
+varnish v1 -cliok "param.set debug +syncvsl"
 
 client c1 {
 	txreq -hdr "Host: foo" -hdr "Host: bar"
@@ -33,12 +34,6 @@ client c2 {
 varnish v1 -vsl_catchup
 varnish v1 -expect client_req_400 == 3
 
-client c3 {
-	stream 3 {
-		txreq -req POST -hdr content-length 12 -hdr content-length 13 -body request
-		rxrst
-	} -run
-} -run
-
-varnish v1 -vsl_catchup
-varnish v1 -expect client_req_400 == 4
+# H2 with multiple content-length runs into thread-scheduling differences,
+# and is unnecessary, as we know the check works from H1 and that it
+# will be hit, because H2 with multiple Host: triggered.


More information about the varnish-commit mailing list