[master] e37c74b7f tweak: Rename the storage tweak to be neutral

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Fri Sep 3 10:38:06 UTC 2021


commit e37c74b7f97a42174f0b73ffc107db6242a9339f
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Fri Sep 3 12:32:57 2021 +0200

    tweak: Rename the storage tweak to be neutral
    
    We could have shortlived_storage and req_body_storage parameters to stop
    requiring Transient for those special cases.
    
    Refs #3661

diff --git a/bin/varnishd/mgt/mgt_param.h b/bin/varnishd/mgt/mgt_param.h
index 29f472299..f31fc1078 100644
--- a/bin/varnishd/mgt/mgt_param.h
+++ b/bin/varnishd/mgt/mgt_param.h
@@ -71,6 +71,7 @@ tweak_t tweak_bytes;
 tweak_t tweak_bytes_u;
 tweak_t tweak_double;
 tweak_t tweak_poolparam;
+tweak_t tweak_storage;
 tweak_t tweak_string;
 tweak_t tweak_thread_pool_min;
 tweak_t tweak_thread_pool_max;
@@ -78,7 +79,6 @@ tweak_t tweak_timeout;
 tweak_t tweak_uint;
 tweak_t tweak_vsl_buffer;
 tweak_t tweak_vsl_reclen;
-tweak_t tweak_h2_rxbuf_storage;
 
 extern struct parspec mgt_parspec[]; /* mgt_param_tbl.c */
 extern struct parspec VSL_parspec[]; /* mgt_param_vsl.c */
diff --git a/bin/varnishd/mgt/mgt_param_tweak.c b/bin/varnishd/mgt/mgt_param_tweak.c
index 192cb5259..2971eaa1b 100644
--- a/bin/varnishd/mgt/mgt_param_tweak.c
+++ b/bin/varnishd/mgt/mgt_param_tweak.c
@@ -491,13 +491,12 @@ tweak_thread_pool_max(struct vsb *vsb, const struct parspec *par,
 }
 
 /*--------------------------------------------------------------------
- * Tweak 'h2_rxbuf_storage'
+ * Tweak storage
  *
  */
 
 int v_matchproto_(tweak_t)
-tweak_h2_rxbuf_storage(struct vsb *vsb, const struct parspec *par,
-    const char *arg)
+tweak_storage(struct vsb *vsb, const struct parspec *par, const char *arg)
 {
 	struct stevedore *stv;
 
diff --git a/include/tbl/params.h b/include/tbl/params.h
index 4e23d7845..8f3eaf8d4 100644
--- a/include/tbl/params.h
+++ b/include/tbl/params.h
@@ -1569,7 +1569,7 @@ PARAM_STRING(
 
 PARAM_STRING(
 	/* name */	h2_rxbuf_storage,
-	/* tweak */	tweak_h2_rxbuf_storage,
+	/* tweak */	tweak_storage,
 	/* priv */	&mgt_stv_h2_rxbuf,
 	/* def */	"Transient",
 	/* descr */


More information about the varnish-commit mailing list