[master] f6dc44eca vbe: Assert to only dequeue queued connection requests

Nils Goroll nils.goroll at uplex.de
Tue Aug 20 09:45:05 UTC 2024


commit f6dc44ecab840a18005c5d4c1c94e0ea6b6c2893
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Tue Aug 20 11:42:42 2024 +0200

    vbe: Assert to only dequeue queued connection requests
    
    Motivated by #4154

diff --git a/bin/varnishd/cache/cache_backend.c b/bin/varnishd/cache/cache_backend.c
index bd60f4e0d..4a0e0a424 100644
--- a/bin/varnishd/cache/cache_backend.c
+++ b/bin/varnishd/cache/cache_backend.c
@@ -191,6 +191,7 @@ static void
 vbe_connwait_dequeue_locked(struct backend *bp, struct connwait *cw)
 {
 	Lck_AssertHeld(bp->director->mtx);
+	assert(cw->cw_state == CW_QUEUED);
 	VTAILQ_REMOVE(&bp->cw_head, cw, cw_list);
 	vbe_connwait_signal_locked(bp);
 	cw->cw_state = CW_DEQUEUED;


More information about the varnish-commit mailing list