[master] d43e225d7 Size pool name buffer for the worst case

Nils Goroll nils.goroll at uplex.de
Mon Jul 29 16:42:07 UTC 2024


commit d43e225d7216ab7f90cd8c2dc7b189a69a7e73e4
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Mon Jul 29 18:39:10 2024 +0200

    Size pool name buffer for the worst case
    
    "999 pools ought to be enough for everyone" yet the actual maximum is UINT_MAX.
    
    Noticed while staring at #4138

diff --git a/bin/varnishd/cache/cache_session.c b/bin/varnishd/cache/cache_session.c
index 898242da3..2a8229e5d 100644
--- a/bin/varnishd/cache/cache_session.c
+++ b/bin/varnishd/cache/cache_session.c
@@ -702,7 +702,7 @@ SES_Rel(struct sess *sp)
 void
 SES_NewPool(struct pool *pp, unsigned pool_no)
 {
-	char nb[8];
+	char nb[4 /* "sess" */ + 10 /* "%u" */ + 1];
 
 	CHECK_OBJ_NOTNULL(pp, POOL_MAGIC);
 	bprintf(nb, "req%u", pool_no);


More information about the varnish-commit mailing list