[master] 05a3d5ccf Spell "FALLTHROUGH" consistently and enable compiler warning for it.
Poul-Henning Kamp
phk at FreeBSD.org
Mon May 13 12:23:07 UTC 2024
commit 05a3d5ccf559ee1d2d9049bfda7db92ecb06f507
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date: Mon May 13 11:18:05 2024 +0000
Spell "FALLTHROUGH" consistently and enable compiler warning for it.
diff --git a/bin/varnishd/cache/cache_rfc2616.c b/bin/varnishd/cache/cache_rfc2616.c
index 90d588e7b..a91c9f862 100644
--- a/bin/varnishd/cache/cache_rfc2616.c
+++ b/bin/varnishd/cache/cache_rfc2616.c
@@ -151,7 +151,7 @@ RFC2616_Ttl(struct busyobj *bo, vtim_real now, vtim_real *t_origin,
* or Expires are present. Uncacheable otherwise.
*/
*ttl = -1.;
- /* FALL-THROUGH */
+ /* FALLTHROUGH */
case 200: /* OK */
case 203: /* Non-Authoritative Information */
case 204: /* No Content */
diff --git a/bin/varnishd/http2/cache_http2_hpack.c b/bin/varnishd/http2/cache_http2_hpack.c
index 5f6f34cf7..c49f9d2b9 100644
--- a/bin/varnishd/http2/cache_http2_hpack.c
+++ b/bin/varnishd/http2/cache_http2_hpack.c
@@ -80,7 +80,7 @@ h2h_checkhdr(struct vsl_log *vsl, txt nm, txt val)
state = FLD_NAME;
if (*p == ':')
break;
- /* FALL_THROUGH */
+ /* FALLTHROUGH */
case FLD_NAME:
if (isupper(*p)) {
VSLb(vsl, SLT_BogoHeader,
@@ -110,7 +110,7 @@ h2h_checkhdr(struct vsl_log *vsl, txt nm, txt val)
return (H2SE_PROTOCOL_ERROR);
}
state = FLD_VALUE;
- /* FALL_THROUGH */
+ /* FALLTHROUGH */
case FLD_VALUE:
if (!vct_ishdrval(*p)) {
VSLb(vsl, SLT_BogoHeader,
diff --git a/wflags.py b/wflags.py
index f9a5bd570..6eb8d112d 100644
--- a/wflags.py
+++ b/wflags.py
@@ -72,7 +72,6 @@ UNDESIRABLE_WFLAGS = [
"-Wno-system-headers", # Outside of our control
"-Wno-thread-safety", # Does not understand our mutexs are wrapped
"-Wno-sign-compare", # Fixable
- "-Wno-implicit-fallthrough", # Probably Fixable
"-Wno-missing-variable-declarations", # Complains about optreset
"-Wno-nullability-completeness", # Barfs all over MacOSx
]
More information about the varnish-commit
mailing list