[master] 8fc1b2c3a vtest: Add "option timeout" to adjust the timeout per test case

Poul-Henning Kamp phk at phk.freebsd.dk
Tue May 28 08:46:35 UTC 2024


--------
Nils Goroll writes:

> commit 8fc1b2c3af3eea0aa0a424fdc6bb76788a9f5661
> Author: Nils Goroll <nils.goroll at uplex.de>
> Date:   Tue May 28 10:38:03 2024 +0200
>
>     vtest: Add "option timeout" to adjust the timeout per test case

I /really/ do not like this.

First:  It overrides constraints which the person running the tests
have laid down.  That is just not OK.  If you could only use it
to shorten timeouts, it would be OK-ish.

Second: It makes assumptions about the platform the test runs on.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-commit mailing list