[master] a5810d25d Coverity: Explain vtc_logfail()

Dridi Boukelmoune dridi at varni.sh
Tue Sep 17 09:06:29 UTC 2024


On Tue, Sep 17, 2024 at 8:41 AM Nils Goroll <nils.goroll at uplex.de> wrote:
>
> On 16.09.24 18:44, Dridi Boukelmoune wrote:
> > Out of curiosity, are you against this instead?
>
> ...
>
> > Alternatively, why not a simple `WRONG("unreachable");` statement
> > instead of a coverity gadget?
>
> I have no idea which of these, if any, work. Neither do I know yet if the
> __coverity_panic__() I added works.

$ git grep WRONG | grep unreachable
flint.lnt:-emacro(527, WRONG)           // unreachable code
vmod/vmod_debug.c:              WRONG("unreachable");

I'll add a WRONG with a comment.


More information about the varnish-commit mailing list