[master] 2802dc94d vtc_log: Simplify Coverity helper

[Dridi Boukelmoune]

commit 2802dc94dbfcc74fdb89fd37ebe6efbc7079a3ad
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Wed Sep 18 14:01:08 2024 +0200

    vtc_log: Simplify Coverity helper

diff --git a/bin/varnishtest/vtc_log.c b/bin/varnishtest/vtc_log.c
index 26bb7302e..549ffdad8 100644
--- a/bin/varnishtest/vtc_log.c
+++ b/bin/varnishtest/vtc_log.c
@@ -109,13 +109,6 @@ vtc_logclose(void *arg)
 	FREE_OBJ(vl);
 }
 
-#ifdef __COVERITY__
-static void v_noreturn_
-vtc_logfail(void)
-{
-	__coverity_panic__();
-}
-#else
 static void v_noreturn_
 vtc_logfail(void)
 {
@@ -125,8 +118,9 @@ vtc_logfail(void)
 		pthread_exit(NULL);
 	else
 		exit(fail_out());
+
+	WRONG("unreachable"); /* Help Coverity Scan see noreturn. */
 }
-#endif
 
 static const char * const lead[] = {
 	"----",