[master] fb28e92fd cache_obj: gc obsolete comment

Nils Goroll nils.goroll at uplex.de
Mon Sep 23 12:23:06 UTC 2024


commit fb28e92fdb34c11aa4a9a890b6130a4366e6af92
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Sun Sep 22 12:46:02 2024 +0200

    cache_obj: gc obsolete comment
    
    Remove a comment which became obsolete with caf49d8b42b97c3599e01f2e503d24991a1a0bcf

diff --git a/bin/varnishd/cache/cache_obj.c b/bin/varnishd/cache/cache_obj.c
index 477b26e2a..9ffa373f3 100644
--- a/bin/varnishd/cache/cache_obj.c
+++ b/bin/varnishd/cache/cache_obj.c
@@ -226,12 +226,6 @@ obj_extend_condwait(const struct objcore *oc)
 		return;
 
 	assert(oc->flags & OC_F_TRANSIENT);
-	/* NB: strictly signaling progress both ways would be prone to
-	 * deadlocks, so instead we wait for signals from the client side
-	 * when delivered_so_far so far is updated, but in case the fetch
-	 * thread was not waiting at the time of the signal, we will see
-	 * updates to delivered_so_far after timing out.
-	 */
 	while (!(oc->flags & OC_F_CANCEL) && oc->boc->fetched_so_far >
 	    oc->boc->delivered_so_far + oc->boc->transit_buffer)
 		(void)Lck_CondWait(&oc->boc->cond, &oc->boc->mtx);


More information about the varnish-commit mailing list