[master] d9d38175a vmod_vtc: Insignificant polish

Walid Boudebouda walid.boudebouda at varnish-software.com
Wed Jul 9 14:43:18 UTC 2025


This has triggered a new CI failure:

vmod_vtc.c:485:9: error: dangling pointer 's' to an unnamed temporary may
> be used [-Werror=dangling-pointer=]
>   485 |         vmod_vsl(ctx, id, tag, side, s);



On Wed, Jul 9, 2025 at 9:34 AM Nils Goroll <nils.goroll at uplex.de> wrote:

>
> commit d9d38175a7c3b9e8ab3568e37d4751d37df0814f
> Author: Nils Goroll <nils.goroll at uplex.de>
> Date:   Wed Jul 9 09:29:01 2025 +0200
>
>     vmod_vtc: Insignificant polish
>
> diff --git a/vmod/vmod_vtc.c b/vmod/vmod_vtc.c
> index 191282b2b..f43995813 100644
> --- a/vmod/vmod_vtc.c
> +++ b/vmod/vmod_vtc.c
> @@ -477,9 +477,10 @@ vsl_line(VRT_CTX, char *str)
>                 return;
>
>         str = strtok_r(NULL, "\r\n", &save);
> -       s = TOSTRAND(str);
>         if (str == NULL)
>                 s = vrt_null_strands;
> +       else
> +               s = TOSTRAND(str);
>
>         vmod_vsl(ctx, id, tag, side, s);
>  }
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20250709/a3541843/attachment-0001.html>


More information about the varnish-commit mailing list