[master] 8a80f7484 vtc-bisect: Ignore good revision in run mode

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Jun 16 09:45:05 UTC 2025


commit 8a80f74846443d04360f648df7aa0c5e1ad6b29e
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Mon Jun 16 11:38:44 2025 +0200

    vtc-bisect: Ignore good revision in run mode
    
    When the good revision is omitted, the vtc-bisect.sh script assumes the
    good revision to be the last tag prior to the bad revision. When it
    calls back to itself to launch an automated git-bisect run, it does so
    without specifying the good/bad revisions because it already set up the
    git-bisect environment.
    
    Once git-bisect is started, git-describe (used to find the tag) may
    fail. Delaying the last tag fallback is enough to avoid this problem.

diff --git a/tools/vtc-bisect.sh b/tools/vtc-bisect.sh
index 7a085a08d..b5e200787 100755
--- a/tools/vtc-bisect.sh
+++ b/tools/vtc-bisect.sh
@@ -125,11 +125,11 @@ BISECT_BAD=${BISECT_BAD:-HEAD}
 MAKE_JOBS=${MAKE_JOBS:-8}
 VTC_FILE=${VTC_FILE:-bisect.vtc}
 
-[ -n "$BISECT_GOOD" ] || BISECT_GOOD=$(git describe --abbrev=0 "$BISECT_BAD")
-
 # run mode short circuit
 "$RUN_MODE" && run
 
+test -n "$BISECT_GOOD" || BISECT_GOOD=$(git describe --abbrev=0 "$BISECT_BAD")
+
 # bisect mode
 ROOT_DIR=$(git rev-parse --show-toplevel)
 


More information about the varnish-commit mailing list