pass_chunked()

Dag-Erling Smørgrav des at linpro.no
Thu Aug 10 11:16:34 CEST 2006


des at linpro.no (Dag-Erling Smørgrav) writes:
> OK, here's what I found:

forgot one -

>>                 u = strtoul(p, &q, 16);
>>                 if (q == NULL || (*q != '\n' && *q != '\r')) {
>>                         INCOMPL();
>>                         /* XXX: move bp to buf start, get more */
>
> easy enough to implement - memmove(), adjust pointers, continue
>
>>                 }
>>                 if (*q == '\r')
>>                         q++;
>>                 assert(*q == '\n');
>>                 q++;
>>                 if (u == 0)
>>                         break;

this is also wrong - we break the loop before sending the final
0-length chunk.

DES
-- 
Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no



More information about the varnish-dev mailing list