If-Modified-Since

[Dag-Erling Smørgrav]

des at linpro.no (Dag-Erling Smørgrav) writes:
> "Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
> > I take it that you have started varnislog so we can nail it next time ?
> Yes.  I expect it will happen again tomorrow morning.

Got one right after lunch:

   13 SessionOpen  c 87.238.44.2 36809
   13 ReqStart     c XID 1143246301
   13 Debug        c State RECV
   13 RxRequest    c GET
   13 RxURL        c /
   13 RxProtocol   c HTTP/1.1
   13 RxHeader     c Host: vg.no
   13 RxHeader     c User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.5) Gecko/20060727 Ubuntu/dapper-security Firefox/1.5.0.5
   13 RxHeader     c Accept: text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5
   13 RxHeader     c Accept-Language: en-us,en;q=0.5
   13 RxHeader     c Accept-Encoding: gzip,deflate
   13 RxHeader     c Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
   13 RxHeader     c Keep-Alive: 300
   13 RxHeader     c Connection: keep-alive
   13 RxHeader     c If-Modified-Since: Tue, 15 Aug 2006 07:05:04 GMT
   13 RxHeader     c If-None-Match: "2b400e-25407-44e17220"
   13 VCL_call     c recv 26 31.14 27 32.13 28 32.49 1 1.22 2 2.9 5 5.5 6 5.9 8 8.5 9 8.9 10 8.34 12 11.5 lookup
   13 Debug        c State LOOKUP
   13 Debug        c State LOOKUP2
   13 Debug        c State MISS
   13 VCL_call     c miss 17 21.22 fetch
   13 Backend      c 14 vg
   13 Debug        c State FETCH
   13 TTL          c 1143246301 RFC 900 1155637301 1155637301 1155638201 900 0
   13 VCL_call     c fetch 18 25.23 19 26.9 21 29.5 22 29.9 24 32.5 insert
   13 ObjProtocol  c HTTP/1.1
   13 ObjStatus    c 200
   13 ObjResponse  c OK
   13 ObjHeader    c Date: Tue, 15 Aug 2006 10:21:41 GMT
   13 ObjHeader    c Server: Apache/1.3.27 (Unix)
   13 ObjHeader    c Cache-Control: max-age=900
   13 ObjHeader    c Expires: Tue, 15 Aug 2006 10:36:41 GMT
   13 ObjHeader    c Last-Modified: Tue, 15 Aug 2006 10:20:48 GMT
   13 ObjHeader    c ETag: "2b400e-25525-44e1a000"
   13 ObjHeader    c Content-Type: text/html; charset=iso-8859-1
   13 ObjHeader    c Content-Length: 152869
   13 Debug        c State DELIVER
   13 Debug        c Cond: 1155637248 <= 1155625504
   13 Length       c 0
   13 TxProtocol   c HTTP/1.1
   13 TxStatus     c 304
   13 TxResponse   c Not Modified
   13 TxHeader     c Date: Tue, 15 Aug 2006 10:21:41 GMT
   13 TxHeader     c Via: 1.1 varnish
   13 TxHeader     c X-Varnish: 1143246301
   13 TxHeader     c Last-Modified: Tue, 15 Aug 2006 10:20:48 GMT
   13 Debug        c State DONE
   13 ReqEnd       c 1143246301 1155637301.279049000 0.000179000 0.103224000 0.000102000

This looks fishy:

                if (ims > sp->obj->last_modified) {
                        VSL(SLT_Debug, sp->fd,
                            "Cond: %d > %d ", sp->obj->last_modified, ims);
                        return (0);
                }

Note how the if test and the debug message disagree.

DES
-- 
Dag-Erling Smørgrav
Senior Software Developer
Linpro AS - www.linpro.no