Child crashes when the backend is down

Poul-Henning Kamp phk at phk.freebsd.dk
Wed May 2 15:59:47 CEST 2007


In message <ujrabwnz5qr.fsf at false.linpro.no>, Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= writes:
>--=-=-=
>Content-Type: text/plain; charset=iso-8859-1
>Content-Transfer-Encoding: quoted-printable
>
>"Poul-Henning Kamp" <phk at phk.freebsd.dk> writes:
>> Obviously nobody else will ever check the busy flag in that case,
>> so the locking isn't necessary.
>
>HSH_Ref() and HSH_Deref() already check that o->objhead !=3D NULL before
>trying to lock the mutex, so I applied the same logic to HSH_Unbusy().
>Is this a suitable fix?

Yes, I think so.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



More information about the varnish-dev mailing list