Fresh patch for Solaris

Poul-Henning Kamp phk at
Mon Aug 11 11:30:39 CEST 2008

In message <57710936-1C6F-457E-AA6D-6BB40DB2CF06 at>, Theo Schlossnagle


OK, I've picked the obvious stuff out.

Various questions about the rest:

Doesn't Solaris have fcntl(F_SETLK) as mandated by POSIX ?
flock() is not a standardized API, and I havn't seen a system yet
which supports it, which doesn't also have fcntl(F_SETLK), so I
would rather not mess up the source with a pointless check.

Do you know for sure that sendfile on Solaris has no reference to the
relevant parts of the file when it returns ?  Otherwise it is not safe
to use.

Why is the extra include of <sys/statvfs.h> necessary in storage_file.c ?

Is there a reason to name the shared object .so instead of .o or is it
just cosmetics ?

In cache_acceptor.c, please implement the "->pass" function which does
the port_send() call.

Why the initialization in mgt_child.c ?

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list