r4480 - trunk/varnish-cache/bin/varnishncsa

Anders Nordby anders at fupp.net
Mon Feb 1 10:35:41 CET 2010


Hi,

I must object to this change, as I use varnishncsa -b extensively to
pull out reports on missed objects being fetch from the backends too
often. Please revert this change, as varnishncsa -b has its use.

Anders.

On Mon, Jan 25, 2010 at 01:19:22PM +0100, kristian at projects.linpro.no wrote:
> Author: kristian
> Date: 2010-01-25 13:19:22 +0100 (Mon, 25 Jan 2010)
> New Revision: 4480
> 
> Modified:
>    trunk/varnish-cache/bin/varnishncsa/varnishncsa.c
> Log:
> Only handle client requests (-c) for varnishncsa
> 
> Fixes	#617
> 
> 
> Modified: trunk/varnish-cache/bin/varnishncsa/varnishncsa.c
> ===================================================================
> --- trunk/varnish-cache/bin/varnishncsa/varnishncsa.c	2010-01-25 11:36:43 UTC (rev 4479)
> +++ trunk/varnish-cache/bin/varnishncsa/varnishncsa.c	2010-01-25 12:19:22 UTC (rev 4480)
> @@ -553,6 +553,13 @@
>  		case 'w':
>  			w_arg = optarg;
>  			break;
> +		case 'b':
> +			fprintf(stderr, "-b is not valid for varnishncsa\n");
> +			exit(1);
> +			break;
> +		case 'c':
> +			/* XXX: Silently ignored: it's required anyway */
> +			break;
>  		default:
>  			if (VSL_Arg(vd, c, optarg) > 0)
>  				break;
> @@ -560,6 +567,8 @@
>  		}
>  	}
>  
> +	VSL_Arg(vd, 'c', optarg);
> +
>  	if (VSL_OpenLog(vd, n_arg))
>  		exit(1);
>  
> 
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at projects.linpro.no
> http://projects.linpro.no/mailman/listinfo/varnish-commit


-- 
Anders.



More information about the varnish-dev mailing list