Review for patch to add derived (calculated) values to the statistics counters reported by libvarnishapi

[Poul-Henning Kamp]

In message <AANLkTikmVfJWyZ+Kp53Bm_2wi+2M6CVdnedvug4WSqhL at mail.gmail.com>, Mart
in Blix Grydeland writes:

>Attached is a patch that will add derived values to the stat counters
>reported by VSC in libvarnishapi. It also adds a derived counter called
>s_avoidedbytes, which shows a rough estimate of how many bytes Varnish has
>saved the backend servers from dealing with.

I like the idea.

Would it be possible to make the formula for deriving the counter
part of the VSC_D() macro ?

Something like:

	VSC_D(s_avoidedbytes,          uint64_t, 0, 'a',
	   "Avoided backend bytes (derive d)",
	   ((ptr)->s_hdrbytes + (ptr)->s_bodybytes ...))


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.