Patch review for adding locking on the SHMFILE to prevent multiple varnish instances using the same -n argument

Poul-Henning Kamp phk at phk.freebsd.dk
Tue Jun 14 13:47:36 CEST 2011


Looks good.

commit when tested cross-platform.

In message <BANLkTinA4xy7KUhV9BBsj7q_KPF=-cGfrJn1xkYkMbdUBci1fQ at mail.gmail.com>
, Martin Blix Grydeland writes:
>--===============8734530158992454258==
>Content-Type: multipart/alternative; boundary=bcaec5431bb03d763a04a5aa8aef
>
>--bcaec5431bb03d763a04a5aa8aef
>Content-Type: text/plain; charset=ISO-8859-1
>
>Updated patch at https://gist.github.com/1024738
>
>Changelog: Moved the testing of file locks into a function in libvarnish.
>
>-Martin
>
>On Thu, Jun 9, 2011 at 13:53, Martin Blix Grydeland <
>martin at varnish-software.com> wrote:
>
>> Please find the patch here: https://gist.github.com/1016579
>>
>> Any comments appreciated.
>>
>> -Martin
>>
>> --
>> Martin Blix Grydeland
>> Varnish Software AS
>>
>>
>
>
>-- 
>Martin Blix Grydeland
>Varnish Software AS
>
>--bcaec5431bb03d763a04a5aa8aef
>Content-Type: text/html; charset=ISO-8859-1
>Content-Transfer-Encoding: quoted-printable
>
>Updated patch at=A0<meta http-equiv=3D"content-type" content=3D"text/html; =
>charset=3Dutf-8"><a href=3D"https://gist.github.com/1024738">https://gist.g=
>ithub.com/1024738</a><div><br></div><div>Changelog: Moved the testing of fi=
>le locks into a function in libvarnish.</div>
><div><br></div><div>-Martin<br><br><div class=3D"gmail_quote">On Thu, Jun 9=
>, 2011 at 13:53, Martin Blix Grydeland <span dir=3D"ltr"><<a href=3D"mai=
>lto:martin at varnish-software.com">martin at varnish-software.com</a>></span>=
> wrote:<br>
><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
>x #ccc solid;padding-left:1ex;">Please find the patch here:=A0<a href=3D"ht=
>tps://gist.github.com/1016579" target=3D"_blank">https://gist.github.com/10=
>16579</a><div>
><br></div><div>Any comments appreciated.</div>
><div><br></div><div>-Martin<br clear=3D"all">=A0<br>-- <br>Martin Blix Gryd=
>eland<br>Varnish Software AS<br><br>
></div>
></blockquote></div><br><br clear=3D"all"><br>-- <br>Martin Blix Grydeland<b=
>r>Varnish Software AS<br><br>
></div>
>
>--bcaec5431bb03d763a04a5aa8aef--
>
>
>--===============8734530158992454258==
>Content-Type: text/plain; charset="us-ascii"
>MIME-Version: 1.0
>Content-Transfer-Encoding: 7bit
>Content-Disposition: inline
>
>_______________________________________________
>varnish-dev mailing list
>varnish-dev at varnish-cache.org
>http://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>--===============8734530158992454258==--
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.




More information about the varnish-dev mailing list