Patch review for adding command line macro definitions to varnishtest

Tollef Fog Heen tfheen at varnish-software.com
Mon Mar 21 14:49:18 CET 2011


]] Martin Blix Grydeland 

| Please find a patch for allowing command line option macro definitions to
| varnishtest, which could then be used to replace text in the test scripts.
| The syntax is '-D name=value', which would then expand ${name} into value
| when executing the test script. The specific use case for adding this is to
| have the ability to pass the build directory of the .so library for a
| varnish mod to varnishtest when building modules out-of-tree.

Looks reasonable to me, with a minor stylistic nit:

+				exit (2);

shouldn't this be exit(2); with no space?

-- 
Tollef Fog Heen
Varnish Software
t: +47 21 98 92 64




More information about the varnish-dev mailing list