varnishncsa outage

[Jean-Baptiste Quenot]

Here is more information about this crash:

(gdb) up
(gdb) print *lp
$1 = {df_H = 0x0, df_U = 0x0, df_q = 0x0, df_b = 0x0, df_h = 0x11e56a0
"84.103.222.181", df_m = 0x0, df_s = 0x0, df_t = {tm_sec = 37, tm_min
= 30, tm_hour = 17, tm_mday = 2, tm_mon = 8, tm_year = 111, tm_wday =
5, tm_yday = 244, tm_isdst = 1, tm_gmtoff = 7200,
    tm_zone = 0x11bca30 "CEST"}, df_u = 0x0, df_ttfb = 0x11dbc00
"nan", df_hitmiss = 0x0, df_handling = 0x0, active = 1, complete = 1,
bitmap = 0, req_headers = {vtqh_first = 0x0, vtqh_last = 0x0},
resp_headers = {vtqh_first = 0x0, vtqh_last = 0x0}}

Please find attached a patch that checks for mandatory fields.
Curiously the code was there but disabled.

2011/9/5 Tollef Fog Heen <tfheen at varnish-software.com>:
> ]] Jean-Baptiste Quenot
>
> | It turns to be a good old "segmentation fault" crash, caused by the
> | SLT_ReqEnd tag processing "time to first byte".
>
> No, it's not, it's from:
>
>                case 'm':
>                        VSB_cat(os, lp->df_m);
>                        break;
>
> now why lp->df_m, which is the request method is null, I don't know.
>
> --
> Tollef Fog Heen
> Varnish Software
> t: +47 21 98 92 64
>



-- 
Jean-Baptiste Quenot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Varnish_3.0.1-Skip-log-line-when-a-mandatory-field-is-missing.patch
Type: application/octet-stream
Size: 857 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20110906/c48df231/attachment-0003.obj>