[PATCH 04/10] Don't always check the sign after smp_append_sign().

Martin Blix Grydeland martin at varnish-software.com
Wed Oct 10 16:27:17 CEST 2012


Remove the XXXAZ(smp_chk_sign) after smp_append_sign(), as it causes
heavy unnecessary CPU usage after each sign update. No assertion
reports have come from this test, so there is no reason to expect the
signs not working.
---
 bin/varnishd/storage/storage_persistent_subr.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/bin/varnishd/storage/storage_persistent_subr.c b/bin/varnishd/storage/storage_persistent_subr.c
index f73ae06..a18f2cc 100644
--- a/bin/varnishd/storage/storage_persistent_subr.c
+++ b/bin/varnishd/storage/storage_persistent_subr.c
@@ -128,7 +128,6 @@ smp_append_sign(struct smp_signctx *ctx, const void *ptr, uint32_t len)
 	SHA256_Update(&cx, &ctx->ss->length, sizeof(ctx->ss->length));
 	SHA256_Final(sign, &cx);
 	memcpy(SIGN_END(ctx), sign, sizeof sign);
-XXXAZ(smp_chk_sign(ctx));
 }
 
 /*--------------------------------------------------------------------
-- 
1.7.9.5




More information about the varnish-dev mailing list