[PATCH 07/13] Don't exit on full silo

Martin Blix Grydeland martin at varnish-software.com
Fri Sep 28 16:03:28 CEST 2012

This then also breaks the previous expectation that cur_seg would
always be non-NULL. Change the code to take this into account.

Review comments:

> +       AN(sg);
> Instead of AN, you should just return failure.  We should handle
> malloc failures gracefully where we can easily do so.

Returning failure in this case now.

In both the next two cases, you should consider truncation
> of the new segment, it's silly to waste a full segment if
> the overflow is just one page:

Added XXX-comments on truncation suggestion.

For clarity, always keep left in sync with cur_seg:


Martin Blix Grydeland
Varnish Software AS
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20120928/21b9ba46/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Don-t-exit-on-full-silo.patch
Type: application/octet-stream
Size: 5266 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20120928/21b9ba46/attachment-0001.obj>

More information about the varnish-dev mailing list