[PATCH 10/13] smp_thread() stopping

Martin Blix Grydeland martin at varnish-software.com
Fri Sep 28 16:03:36 CEST 2012

Review comments:

All things considered, we should probably VSL these and live with
> it.   SLT_PersistentEvent or something.

Agreed, logging from persistent needs to be overhauled as a
whole. Putting on todo list.

We should avoid whole-second sleeps, they have a bad tendency to
> get things to run in lockstep.  Ideally each silo should sleep
> for 1+random-small-delta, but at least make it different from 1.0


You should simply let the tread die, and pthread_join() it from
> smp_close().


Martin Blix Grydeland
Varnish Software AS
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20120928/220fdabe/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-smp_thread-stopping.diff
Type: application/octet-stream
Size: 3393 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20120928/220fdabe/attachment.obj>

More information about the varnish-dev mailing list