[PATCH 1/2] Turn on SO_KEEPALIVE on all TCP connections.

[Poul-Henning Kamp]

Content-Type: text/plain; charset=ISO-8859-1
--------
In message <1360591798-25870-1-git-send-email-martin at varnish-software.com>, Mar
tin Blix Grydeland writes:

>On platforms that support it also add runtime parameters to control
>the keep-alive packet settings through socket options. On platforms
>that don't support these socket options, the values must be set system
>wide.

I think "TCP_KEEP_WORKS" is misnamed, auto* doesn't actually test if
it works, but only that it does not fail the setsockopt, it should be
an "HAVE_TCP_KEEP" option.

That said, which operating system does _not_ have it ?

If all relevant kernels have it, there is no reason to pollute the
source with #ifdefs and autocrappery.

Poul-Henning

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.