[PATCH] logexpect only attempts regex matches for matching tags

[Martin Blix Grydeland]

Hi Geoff,

The intention was exactly as you guess, that the regular expression should
only be applied to records that has the tag that goes with the regex. So
this is indeed a bug. I will apply the patch. Thanks :)

Martin


On 10 October 2013 11:59, Geoff Simmons <geoff at uplex.de> wrote:

> Hello all,
>
> Sorry about that empty mail.
>
> While trying to learn to use logexpect, I noticed that for expectations
> like these:
>
> expect 0 * FixedTag
> expect * = FooTag reg.x*
>
> ... it would attempt the regex match for every log entry after the
> FixedTag, regardless of whether the entry has the FooTag. It continues
> until it hits an entry with a match, which may or may not have the FooTag.
>
> I may have misunderstood the intention here, but the attached patch
> ensures that the regex match is only attempted for log entries with the
> expected tag.
>
>
> Best,
> Geoff
> --
> ** * * UPLEX - Nils Goroll Systemoptimierung
>
> Scheffelstraße 32
> 22301 Hamburg
>
> Tel +49 40 2880 5731
> Mob +49 176 636 90917
> Fax +49 40 42949753
>
> http://uplex.de
>
> _______________________________________________
> varnish-dev mailing list
> varnish-dev at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev
>



-- 
<http://varnish-software.com>*Martin Blix Grydeland*
Senior Developer | Varnish Software AS
Cell: +47 21 98 92 60
We Make Websites Fly!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20131011/f78554e1/attachment.html>