[PATCH] Skip NULL arguments when hashing. Hash all arguments.

Nils Goroll nils.goroll at uplex.de
Tue Aug 12 00:05:44 CEST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

When multiple arguments were passed to vmod_hash_backend, only the
first argument was re-used for the number of arguments passed.

Fixes #1568


Re phk on irc: I don't see how we should handle NULL differntly from "". If no
bytes are processed, the hash does not change.

Nils

- -- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.ccc.de/

http://uplex.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlPpPjYACgkQYhlPtokm/hv19gCfXpqBNwfB2QxNIW+OrWqHENEk
B9cAoJzKjz2G2pTErNDMnUMvyI0brGUl
=9zp+
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Skip-NULL-arguments-when-hashing.-Hash-all-arguments.patch
Type: text/x-patch
Size: 2021 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140812/73c65bc4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Skip-NULL-arguments-when-hashing.-Hash-all-arguments.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140812/73c65bc4/attachment.pgp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4528 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140812/73c65bc4/attachment-0001.bin>


More information about the varnish-dev mailing list