PATCH: vary on gzip

[Federico Schwindt]

Attached is a new diff based on our discussion on irc.
This is now handled within the vfps and thus will happen after
vcl_backend_response and the inserted object will include the Vary header.

The caveat with this approach, at least in the current implementation, is
that disabling http_gzip_support won't have any effect on existing objects
but I can't see this being an issue.



On Tue, Aug 26, 2014 at 1:26 PM, Poul-Henning Kamp <phk at phk.freebsd.dk>
wrote:

> --------
> In message <CAJV_h0bfQstBU=hQ60=
> HDhAyp8AGwVhRx30_OBdQ10Sp4R1ufA at mail.gmail.com>
> , Federico Schwindt writes:
>
> >Does this mean that doing it in vfp_gzip_init() or cache_gzip.c would be
> >appropriate or preferred?
>
> I probably lost context for "it" here :-)
>
> But if you look in -trunk, you'll see for instance vfp_gzip_init()
> doing:
>
>         if (vfe->vfp->priv2 == VFP_GUNZIP || vfe->vfp->priv2 == VFP_GZIP) {
>                 http_Unset(vc->http, H_Content_Encoding);
>                 http_Unset(vc->http, H_Content_Length);
>                 RFC2616_Weaken_Etag(vc->http);
>         }
>
>
> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk at FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD committer       | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140827/0553a9a4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0000-gzip-vary.patch
Type: text/x-patch
Size: 7487 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140827/0553a9a4/attachment.bin>