[PATCH] Add a recycle_maxage attribute to backend definitions.

[Martin Blix Grydeland]

Hi,

I guess the check of the list tail for expired ones could be moved to the
BackendClose()/BackendRecycle() functions which are called after the fetch
has finished and as such shouldn't create any delays for anything. Though I
wouldn't expect this to have any significant impact on fetch times, it
would probably be just one connection being closed at a time and compared
to the fetch operation the time spent is negligible.

Having a nanny thread for this part is in my opinion too much complexity
for little gain. Having a single worker servicing all of the backends would
create some interesting locking complexity and resource freeing headaches.
Having one per backend would be easy to implement, but would add too much
resource usage for little benefit.

Nils: A review would be much appreciated.

Martin


On 27 August 2014 20:35, Nils Goroll <slink at schokola.de> wrote:

> Hi Martin,
>
> it's cool you are addressing this issue, thanks. I have not tested your
> patch
> (yet) but at first sight it looks good to me. If no-one else did a real
> review
> and phk thinks it is necessary, I could probably do it on Friday.
>
> While your patch appears to be a real improvement which I'd like to see
> integrated, I still think we should have some backend connection nanny
> thread
> doing this work preventatively and out of context of the backend thread
> desperately in need of a backend connection.
>
> Cheers, Nils
>



-- 
<http://varnish-software.com>*Martin Blix Grydeland*
Senior Developer | Varnish Software AS
Cell: +47 21 98 92 60
We Make Websites Fly!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140828/62d3d4da/attachment.html>