[PATCH] [EXPERIMENTAL] autocrap autohardening

Tollef Fog Heen tfheen at varnish-software.com
Thu Jan 30 08:48:48 CET 2014


]] Nils Goroll

> I stumbled over http://mainisusuallyafunction.blogspot.de/2012/05/automatic-binary-hardening-with.html
> today and thought to give it a try with varnish.

I think this is a good idea, just a minor comment:

> +# We use the same hardening flags for C.  We must check that each flag
> +# is supported by both compilers.
> +AC_DEFUN([check_cc_flag],
> + [AX_CHECK_COMPILE_FLAG([$1], [$2], [$3], [-Werror $4])])
> +AC_DEFUN([check_link_flag],
> + [AX_CHECK_LINK_FLAG([$1], [$2], [$3], [-Werror $4])])

auto* function names are generally uppercase, so uppercase those too,
please?

-- 
Tollef Fog Heen
Technical lead | Varnish Software AS
📞: +47 21 98 92 64
We Make Websites Fly!



More information about the varnish-dev mailing list