[PATCH 3/3] Do not reset bereq on retry. Add rollback_bereq for this, purpose.

Federico Schwindt fgsch at lodoss.net
Tue Jul 22 14:25:25 CEST 2014

I agree, it'd be better and if it's possible in the future we can switch to
it but splitting rollback is a one way road.

There are other places checking ctx->method so it should be fine.

On Tue, Jul 22, 2014 at 12:38 PM, Nils Goroll <slink at schokola.de> wrote:

> Hi Federico,
> On 22/07/14 02:26, Federico Schwindt wrote:
> > I've changed your diff to avoid splitting rollback. I don't think we
> should make
> > that distinction.
> I had considered this approach also (see yesterday's irc log) but ditched
> it
> because I thought checking context in VCC would be better than checking at
> runtime - and VCC would have required more attention to become "context
> sensitive".
> Other than that I am fine with your change in principle - but I have not
> tested it.
> Nils
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20140722/6d4bf3e4/attachment.html>

More information about the varnish-dev mailing list