[PATCH 3/3] Do not reset bereq on retry. Add rollback_bereq for this, purpose.

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Jul 30 10:01:26 CEST 2014

In message <CAJV_h0bR-h=i0e-GKwZrd5fE9q-1AsF=_sJ=gFJQ=6CbiF0kow at mail.gmail.com>
, Federico Schwindt writes:

Two things, on trivial-ish and the other serious-ish.

The trivial thing is that I think we should put the actual
rollback in VRT_Rollback() (give it an VCL_HTTP argument) so that
std.rollback just wraps that.

The other thing is that I'm not even close to being convinced that
resetting the workspace is safe anymore, and I have no idea how I
can convince myself that it is, in a world full of VMODs.

We may have to give up on that, and only rollback the struct http.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list