[PATCH] Backport a fix for CLI protocol failure to 3.0.6

[Geoff Simmons]

Hello all,

The patch in the attachment backports commit 2144dc78, a fix for
mgt_cli.c, to version 3.0.6. The fix catches one of conditions for
calling MGT_Child_Cli_Fail() that had previously been missed. The patch
would have to be applied to the 3.0 branch.

When the CLI between management and child processes gets out of sync,
MGT_Child_Cli_Fail() causes the CLI connection to be closed and re-opened.

We were seeing the effect (on both 3.0.3 and 3.0.6) that 'varnishadm
vcl.list' occasionally returned the output of backend.list --
backend.list was being called by monitoring tools at the same time. The
problem has gone away since we applied the patch.

So if there's ever a 3.0.7, then I suggest that this fix be included.


Best,
Geoff
-- 
** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

Tel +49 40 2880 5731
Mob +49 176 636 90917
Fax +49 40 42949753

http://uplex.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-better-criteria-for-determining-if-child-CLI-con.patch
Type: text/x-patch
Size: 1281 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20141122/d632e6af/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20141122/d632e6af/attachment.pgp>