[PATCH] HTTP date parsing and formatting

Dridi Boukelmoune dridi.boukelmoune at zenika.com
Tue Feb 24 13:08:05 CET 2015


On Tue, Feb 24, 2015 at 10:26 AM, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> --------
> In message <CABtDKm4ZYZFbJBrSAa5_L8MYko5SpgpJ09q0M_V=j8_G6zCQVQ at mail.gmail.com>
> , Dridi Boukelmoune writes:
>
>>I have a set of patches that serve two purposes:
>>- fixing the current date parsing
>>- not breaking when the locale changes
>
> I think I have solved these issues now.

Yes, my test is passing (see below)

> Thank you for sending patches, even though I hardly used them
> in this case, mostly because I wanted to go a little deeper in the
> solution than you did.

A "little" :-)

I have one question though.

Why did you keep the ISO 8601 format for parsing?

Also please find my first patch rebased against the current master.
It's an improvement of m00020.vtc (testing both parsing and
formatting) and it adds a setlocale capability to the debug vmod.

Best Regards,
Dridi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-a-new-function-VOID-debug.setlocale-STRING.patch
Type: text/x-patch
Size: 3438 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150224/cd3c2987/attachment.bin>


More information about the varnish-dev mailing list