[PATCH] HTTP date parsing and formatting

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Feb 25 10:53:26 CET 2015

In message <CABtDKm5rpO4K2N8FJkrrW31LW9T-7+RMrJ5ompkfCi4+6pdPqg at mail.gmail.com>
, Dridi Boukelmoune writes:

>I'm setting a different locale for this very test (also part of the
>patch) but it could be handy in other places.

Yeah, but now that we've rewritten the vtim.c code to not be locale
dependent, that's sort of pointless ?

>In my initial patch set, I had added it to show how a vmod could
>compromise the child's locale. You have removed some str?time and
>strtod calls from the code base but there could be other occurrences
>to replace (and other functions in libc to not use).

Right, but then we'll tackle it in that context, it doesn't belong
in m00020 any more.

>As I said in my first email, I am willing to continue submitting
>locale-related patches, so debug.setlocale would help.

By all means use it to find such trouble!   I just don't see the point
in adding it to the vmod on a permanent basis, unless we have code
we specifically need to test.

(Remember: Not all machines may have any given locale installed...)

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list