[PATCH] Add support to scale fields in varnishstat(1)

Federico Schwindt fgsch at lodoss.net
Wed Jan 7 15:37:40 CET 2015


I prefer to let the user decide (i.e. no auto-scaling). This is what top in
linux does as well.
The changes required were small enough as well.

That said if the consensus is to go for auto-scaling that's fine with me.

Regarding adding the i to the unit, I've kept it brief on purpose to
maintain the width as wide as possible.
I've documented the units so this shouldn't be a problem. Also this is how
top displays it.

On Wed, Jan 7, 2015 at 11:49 AM, Nils Goroll <slink at schokola.de> wrote:

> Hi,
>
> I've reviewed and tested the patches and they look fine to me.
>
> But my personal preference would be auto-scaling per value, for instance
> so that
> you never get more than 3 digits or using the next unit when reaching 90%
> of its
> base value.
>
> I'd suggest a -h(uman readable) command line option plus an interactive
> toggle key.
>
> If there is a good use case for manual sc(e)ling is, I don't mind keeping
> it.
>
> Nils
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150107/6064d579/attachment.html>


More information about the varnish-dev mailing list