Test suite for dynamic backends

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Jul 8 00:55:44 CEST 2015

In message <CABoVN9C3U444oYsO2yHfFm-Kr9d3OhTBexSO=bkmPUFcZX7smg at mail.gmail.com>
, Dridi Boukelmoune writes:

>As requested, I have prepared a test suite for dynamic backends. This
>patch set also contains API changes and bug fixes (see #1755).

>Subject: [PATCH 1/5] Change the VRT API for adding/deleting backends

> A VRT_CTX may not be available in all situations for backends deletion.

They will have to be.  If need be, the caller must construct one.

> Adding a backend to a warm VCL needs a proper initialization of the
> backend, through an event.

Fixed slightly simpler than in your patch.

> Events can now be sent outside of the CLI thread for dynamically-created
> backends.

Also fixed.

>Subject: [PATCH 2/5] Keep track of backends references and connections

I've done this entirely differently.

Fixes #1755

> [PATCH 3/5] Add a debug.sleep(DURATION) synchronization helper

>+	sleep((unsigned int)t);

This should use VTIM_sleep().

Commit it when fixed & tested.

> Subject: [PATCH 4/5] Add a test suite for dynamic backends

I've run out of steam, will look at this tomorrow.

> Subject: [PATCH 5/5] Add more information to a backend panic message

This doesn't work with the way I did #2/5 above.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list