Adding -b (buffer size) parameter to varnishtest

Carlos Abalde carlos.abalde at gmail.com
Thu Sep 10 16:50:50 CEST 2015


> On 10 Sep 2015, at 15:00, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> 
> --------
> In message <CABoVN9C=f53dbP-KogJ7Cepb1t_vZjDpfTgSaCu6Ptdw8GB05Q at mail.gmail.com>
> , Dridi Boukelmoune writes:
>> On Thu, Sep 10, 2015 at 1:26 PM, Carlos Abalde <carlos.abalde at gmail.com> wrote:
>>> Hi,
>>> 
>>> When implementing in VCL complex logic (not necessarily related with caching contents -e.g. access control, rate limiting, etc.-) varnishtest is a powerful tool to automate VCL testing. These type of tests sometimes are complex and they are not easy to split in smaller pieces.
>> 
>> Hi Carlos,
>> 
>> One nitpick: I believe it should display the default value in the man
>> (and maybe usage too).
> 
> Also, please use the VNUM_2bytes() function so one can write "512K"
> rather than a implied "K"

Hi,

Thanks! New patch attached: improved docs (default value, alphabetical order) and now using VNUM_2bytes() function.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-buffer-size.patch
Type: application/octet-stream
Size: 2787 bytes
Desc: not available
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150910/f2bfb40b/attachment.obj>
-------------- next part --------------


Best,

--
Carlos Abalde



More information about the varnish-dev mailing list