[PATCH] Log 'set beresp.uncacheable = true' occurrences

[Federico Schwindt]

On Fri, Sep 11, 2015 at 4:07 PM, Dridi Boukelmoune <dridi at varni.sh> wrote:

> On Fri, Sep 11, 2015 at 4:54 PM, Federico Schwindt <fgsch at lodoss.net>
> wrote:
> > I don't have an opinion either.
> > That said, this variable is also set for passes. In that case people
> > checking this variable will find it set but there won't be any logging.
>
> Isn't it bereq.uncacheable that is set for passes?
>

>From the docs: Inherited from bereq.uncacheable, see
there.


>
> > Not sure if that's an issue but I'd argue is not consistent.
>
> Maybe I should use a better name instead? This is logged when VCL sets
> this variable, not varnishd itself.
>

That's my concern. It will only appear when it's set from VCL.
As a counter example, the TTL tag is logged when it's changed from code
(varnishd) and VCL using "RFC" and "VCL", respectively.

Either way, it might be ok, no further opinion really.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150911/fb5c8e6e/attachment.html>