[PATCH] Log 'set beresp.uncacheable = true' occurrences
fgsch at lodoss.net
Fri Sep 11 17:22:38 CEST 2015
On Fri, Sep 11, 2015 at 4:07 PM, Dridi Boukelmoune <dridi at varni.sh> wrote:
> On Fri, Sep 11, 2015 at 4:54 PM, Federico Schwindt <fgsch at lodoss.net>
> > I don't have an opinion either.
> > That said, this variable is also set for passes. In that case people
> > checking this variable will find it set but there won't be any logging.
> Isn't it bereq.uncacheable that is set for passes?
>From the docs: Inherited from bereq.uncacheable, see
> > Not sure if that's an issue but I'd argue is not consistent.
> Maybe I should use a better name instead? This is logged when VCL sets
> this variable, not varnishd itself.
That's my concern. It will only appear when it's set from VCL.
As a counter example, the TTL tag is logged when it's changed from code
(varnishd) and VCL using "RFC" and "VCL", respectively.
Either way, it might be ok, no further opinion really.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the varnish-dev