[PATCH] Log 'set beresp.uncacheable = true' occurrences

Federico Schwindt fgsch at lodoss.net
Sat Sep 12 12:55:23 CEST 2015

Since nitpicking is my name:

> +                       VSLb(bo->vsl, SLT_Uncacheable, "Illegal Vary

Before this there is a SLT_Error with "Illegal 'Vary' header from backend,
making this a pass.". Repeating the reason here seems redundant.

> +       if (bo->do_pass) {
> +               bo->uncacheable =
> +               VSLb(bo->vsl, SLT_Uncacheable, "bereq");
> +       }

We could argue that this is uncacheable at the time we returned pass. Also
"bereq" doesn't really tell us anything.
Furthermore, doing it in here will result in this being logged twice in
some cases.

On Fri, Sep 11, 2015 at 5:48 PM, Dridi Boukelmoune <dridi at varni.sh> wrote:

> > Either way, it might be ok, no further opinion really.
> New patch based on your feedback :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150912/587a5820/attachment.html>

More information about the varnish-dev mailing list