[PATCH] Log 'set beresp.uncacheable = true' occurrences

Federico Schwindt fgsch at lodoss.net
Sat Sep 12 15:58:13 CEST 2015


On Sat, Sep 12, 2015 at 1:52 PM, Dridi Boukelmoune <dridi at varni.sh> wrote:

> [..]
> > I'd rather move it where it belongs, that is where do_pass is set to 1.
>
> But do_pass is bereq.uncacheable, and until you actually get a
> response from the backend I don't think it would make sense to log
> that beresp.uncacheable has been set.
>

You are not logging that beresp.uncacheable has been set in this case
though, you're logging the fact that the response won't be cacheable.
It'd be different if it's done in VCL.

Personally I think it will be less confusing if we log things as they
occur. YMMV.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-dev/attachments/20150912/d9e03780/attachment.html>


More information about the varnish-dev mailing list