[PATCH] Automatically expand vmod_* macros in varnishtest

Dridi Boukelmoune dridi at varni.sh
Thu Feb 18 09:21:10 CET 2016


On Thu, Feb 18, 2016 at 12:45 AM, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> --------
>
> I think we decided to change the vcl_dir and vmod_dir parameters to be
> paths rather than single directories.
>
> If we got that in, we could get totally rid of the ${vmod_*} magic

Would it mean that we'd retire the ${vmod_*} macros in varnishtest and
the test suite?

> instead, and have varnishtest -i set vmod_path apropriately.

We also need a way to set a vmod_path for VMOD writers. Something
like varnishtest -p /path/to/vmod_dir:$libdir/varnish/vmods when building
the VMOD.

> That sounds like a better idea to me...

varnishtest -i already sets the PATH for the programs, should those
macros also be retired and leave it to varnishtest users to set an
appropriate PATH?

I have already submitted such a change in vmod-example to get all
programs from the PATH and not just varnishd.



More information about the varnish-dev mailing list