make ENABLE_TESTS default?

Nils Goroll slink at schokola.de
Wed Mar 2 11:47:10 CET 2016


On 02/03/16 09:51, Guillaume Quintard wrote:
> Can we get rid of the "if ENABLE_TESTS"? Tests should be executed. If you don't
> want to run them, don't run "make check".

This seems to be an ancient addition, I cant' see any use for disabling tests
and I agree that tests should just be enabled by default.

commit 35b895fd01ee23c4a2889fa3d0fe04c2358baf80
Author: Dag Erling Smørgrav <des at des.no>
Date:   Wed Feb 13 13:05:36 2008 +0000

    Some source files (especially in libraries) have embedded test
    programs.  Add a configure option and a corresponding automake
    conditional to enable these tests.


    git-svn-id: http://www.varnish-cache.org/svn/trunk/varnish-cache@2453
d4fa192b-c00b-0410-8231-f00ffab90ce4

diff --git a/configure.ac b/configure.ac
index 5197c1f..204124f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -293,6 +293,11 @@ AC_ARG_ENABLE(stack-protector,
        AS_HELP_STRING([--enable-stack-protector],[enable stack protector
(default is NO)]),
        CFLAGS="${CFLAGS} -fstack-protector-all")

+# --enable-tests
+AC_ARG_ENABLE(tests,
+       AS_HELP_STRING([--enable-tests],[build test programs (default is NO)]))
+AM_CONDITIONAL([ENABLE_TESTS], [test x$enable_tests = xyes])
+
 # --enable-werror
 AC_ARG_ENABLE(werror,
        AS_HELP_STRING([--enable-werror],[use -Werror (default is NO)]),




More information about the varnish-dev mailing list