[PATCH] improve the vbm facility and fix an off-by-one error

Poul-Henning Kamp phk at phk.freebsd.dk
Thu Mar 3 00:26:56 CET 2016


--------
In message <56D5D0B0.1010606 at schokola.de>, Nils Goroll writes:

>- fix an off-by-one in vbit_set

Please fix this in a stand-alone commit.

>- add VBITMAP_INITIALIZE() for on-stack use of struct vbitmap

I am *really* alergic to alloca(), so please make a case for here
this is a good idea ?

>- change the allocation scheme to pow2()

I'm not sure I understand what you mean here ?

>- add a test program

Always a good idea.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



More information about the varnish-dev mailing list