Devon H. O'Dell
dho at fastly.com
Fri May 19 16:17:14 CEST 2017
On Fri, May 19, 2017 at 1:08 AM, Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> In message <CADe=ujbko6ohS7L=gYj0AhnS1vdqSa5xpFznAg2Us=G=Ee1CFg at mail.gmail.com>, "Devon H. O'Dell" writes:
>>In case JSON ends up being a thing, [...]
>>Unsure whether strict correctness is required, but it certainly can't
>>hurt (especially if folks end up building e.g. VMODs on top of it).
> Thus inspired I just tested my code agains the testsuite, and after
> one small tweak it passes all the Yes/No tests.
> The "i_" and transform testcases gets various results: I don't
> transform numbers to C numeric types, so I don't find all the ieee64
> overflows, and I'm not being anal about unicode either.
Cool! The unspecified stuff is wiggly; I didn't care much about one
way or the other on that, either.
>  I my check for control-chars in strings I forgot that char is signed.
Except when it isn't! Whether "plain" char is signed or unsigned is
implementation-defined (§6.2.5p3, §184.108.40.206p3). (But I guess the fix
was making the thing unsigned char, so it doesn't matter anyway :)).
More information about the varnish-dev