[6.1] 2f2387038 Fix gensequences for BusyBox awk

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Nov 7 11:00:55 UTC 2018


--------

Why is this fix not in -trunk ?

Poul-Henning

In message <20181107091318.F3356ACEF1 at lists.varnish-cache.org>, Pål Hermunn Johanse
n writes:
>
>commit 2f2387038a7b9aca4c31c0f839cda3b7ab3391c0
>Author: Guillaume Quintard <guillaume at varnish-software.com>
>Date:   Thu Apr 26 21:59:41 2018 +0200
>
>    Fix gensequences for BusyBox awk
>    
>    I never thought that I'd have to fix a string concatenation problem in
>    a BusyBox awk program to generate VT100 code in a container, but here we
>    are:
>    
>    echo | awk 'END {print "foo" "" ++a, "foo" ++a}'
>    
>    should output "foo0 foo1", and for all the ?awk I tested, it does,
>    except for BusyBox awk who thought funny to output "0 foo1", breaking the
>    teken_state.h file.
>
>diff --git a/bin/varnishtest/gensequences b/bin/varnishtest/gensequences
>index 4337186b8..18a68b43b 100644
>--- a/bin/varnishtest/gensequences
>+++ b/bin/varnishtest/gensequences
>@@ -70,7 +70,7 @@ while (getline > 0) {
> 		l_prefix_parent[n] = prefix;
> 		l_prefix_suffix[n] = sequence[i];
> 		if (!l_prefix_name[n])
>-			l_prefix_name[n] = "teken_state_" ++npr;
>+			l_prefix_name[n] = "teken_state_" "" ++npr;
> 		prefix = n;
> 	}
> 
>_______________________________________________
>varnish-commit mailing list
>varnish-commit at varnish-cache.org
>https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
>

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-dev mailing list