From phk at phk.freebsd.dk  Tue Jun  4 07:16:37 2019
From: phk at phk.freebsd.dk (Poul-Henning Kamp)
Date: Tue, 04 Jun 2019 07:16:37 +0000
Subject: VCC now has type-driven properties
Message-ID: <89245.1559632597@critter.freebsd.dk>

As you may have spotted in recent commits and notably 2962375b4ed80e,
VCC now has type driven properties.

This means that subexpressions of a given type can express that
property, no matter how we got to it in the first place.

If we defined a type driven property from DURATION called
"foobar" it would be possible to write:

	set beresp.http.qqq = (beresp.ttl + 4m).foobar;

Right now, this has not changed the syntax of VCL, we're still 4.1
because the only use is for the storage.*.* variables for which
the syntax remains the exact same.

If we want to, some of the stuff in vmod_std can now be made
slightly more intutive syntax-wise:

	BACKEND.healthy -> BOOL

	IP.port -> INT

Note that these are *properties* `EXPR.name` they do not take any
VCL arguments beside the expression they work on.  (The C-implementation
can of course take other args, like VRT_CTX)

It would not be too hard to also do *methods* `EXPR.func(args)`,
so that one could also do things like:

	set bereq.http.qqq = beres.ttl.format("%.3f")

But I am not going to implement that until we have more convincing
use cases than that.

A bit more work would be to allow vmods to implement type driven
properties and methods, but again:  Convincing use cases ?.

Proposals and ideas are welcome.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

From phk at phk.freebsd.dk  Thu Jun 20 09:28:55 2019
From: phk at phk.freebsd.dk (Poul-Henning Kamp)
Date: Thu, 20 Jun 2019 09:28:55 +0000
Subject: STRING_LIST deorbit burn completed
Message-ID: <62697.1561022935@critter.freebsd.dk>

I have removed the remaining uses of STRING_LIST in the tree, and
made vmodtool.py be slightly annoying if it is used.

vmodtool.py will get more and more annoying about this over summer
and around august 1st, it will refuse to compile it.

The replacement is of course STRANDS.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

From dridi at varni.sh  Thu Jun 20 10:19:43 2019
From: dridi at varni.sh (Dridi Boukelmoune)
Date: Thu, 20 Jun 2019 10:19:43 +0000
Subject: [bugwash] Retire hash_data() from VCL 4.2
Message-ID: <CABoVN9A8W2NH8_rY+601gv=yiLuadpaxidCN9+u07RXeRPASuQ@mail.gmail.com>

Hello,

I would like to add the following item to the next bugwash agenda:

> 11:34 < dridi> phk: around?
> 11:35 < dridi> on the topic of vcl 4.2, and considering your recent commits
> 11:36 < dridi> would it make sense to retire the hash_data function in vcl 4.2?
> 11:36 < dridi> replacement would be hash_string, hash_lowercase (host is case-insensitive) and hash_blob (mainly req body)
> 11:37 < dridi> of course hash_data would have to remain for vcl < 4.2
> 11:38 < dridi> but the new functions could be made available in vcl 4.[01] too
> 11:52 < phk> dridi, for a few minutes
> 11:52 < phk> dridi, I think that is bugwash material ?

I would also encourage changing the built-in VCL to use the new
functions in vcl_hash.

Dridi

From dridi at varni.sh  Fri Jun 21 12:57:28 2019
From: dridi at varni.sh (Dridi Boukelmoune)
Date: Fri, 21 Jun 2019 12:57:28 +0000
Subject: STRING_LIST deorbit burn completed
In-Reply-To: <62697.1561022935@critter.freebsd.dk>
References: <62697.1561022935@critter.freebsd.dk>
Message-ID: <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>

On Thu, Jun 20, 2019 at 9:29 AM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
>
> I have removed the remaining uses of STRING_LIST in the tree, and
> made vmodtool.py be slightly annoying if it is used.

Not quite:

Making all in libvmod_directors
########################################################################

STRING_LIST will be discontinued before the 2019-09-15 release

Please switch to STRANDS
########################################################################

Same for vmod-vtc.

Dridi

> vmodtool.py will get more and more annoying about this over summer
> and around august 1st, it will refuse to compile it.
>
> The replacement is of course STRANDS.
>
> --
> Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
> phk at FreeBSD.ORG         | TCP/IP since RFC 956
> FreeBSD committer       | BSD since 4.3-tahoe
> Never attribute to malice what can adequately be explained by incompetence.
> _______________________________________________
> varnish-dev mailing list
> varnish-dev at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

From phk at phk.freebsd.dk  Fri Jun 21 13:01:42 2019
From: phk at phk.freebsd.dk (Poul-Henning Kamp)
Date: Fri, 21 Jun 2019 13:01:42 +0000
Subject: STRING_LIST deorbit burn completed
In-Reply-To: <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>
References: <62697.1561022935@critter.freebsd.dk>
 <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>
Message-ID: <7692.1561122102@critter.freebsd.dk>

--------
In message <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q at mail.gmail.com>
, Dridi Boukelmoune writes:
>On Thu, Jun 20, 2019 at 9:29 AM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
>>
>> I have removed the remaining uses of STRING_LIST in the tree, and
>> made vmodtool.py be slightly annoying if it is used.
>
>Not quite:

Right now I'm trying to get the message out, the annoyance will be
adjusted continuously.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

From dridi at varni.sh  Fri Jun 21 13:57:40 2019
From: dridi at varni.sh (Dridi Boukelmoune)
Date: Fri, 21 Jun 2019 13:57:40 +0000
Subject: STRING_LIST deorbit burn completed
In-Reply-To: <7692.1561122102@critter.freebsd.dk>
References: <62697.1561022935@critter.freebsd.dk>
 <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>
 <7692.1561122102@critter.freebsd.dk>
Message-ID: <CABoVN9B+fkoTk9g0KfaqB4jt9bwhgHdKPRja468N79D_5FgnAA@mail.gmail.com>

On Fri, Jun 21, 2019 at 1:01 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
>
> --------
> In message <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q at mail.gmail.com>
> , Dridi Boukelmoune writes:
> >On Thu, Jun 20, 2019 at 9:29 AM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:
> >>
> >> I have removed the remaining uses of STRING_LIST in the tree, and
> >> made vmodtool.py be slightly annoying if it is used.
> >
> >Not quite:
>
> Right now I'm trying to get the message out, the annoyance will be
> adjusted continuously.

My point was rather that "all uses of STRING_LIST in the tree" aren't
removed yet:

    $ git grep STRING_LIST -- lib/libvmod_*
    lib/libvmod_directors/vmod.vcc:$Method BACKEND .backend(STRING_LIST)
    lib/libvmod_vtc/vmod.vcc:$Function VOID panic(STRING_LIST)

Dridi

From phk at phk.freebsd.dk  Fri Jun 21 14:31:21 2019
From: phk at phk.freebsd.dk (Poul-Henning Kamp)
Date: Fri, 21 Jun 2019 14:31:21 +0000
Subject: STRING_LIST deorbit burn completed
In-Reply-To: <CABoVN9B+fkoTk9g0KfaqB4jt9bwhgHdKPRja468N79D_5FgnAA@mail.gmail.com>
References: <62697.1561022935@critter.freebsd.dk>
 <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>
 <7692.1561122102@critter.freebsd.dk>
 <CABoVN9B+fkoTk9g0KfaqB4jt9bwhgHdKPRja468N79D_5FgnAA@mail.gmail.com>
Message-ID: <8184.1561127481@critter.freebsd.dk>

--------
In message <CABoVN9B+fkoTk9g0KfaqB4jt9bwhgHdKPRja468N79D_5FgnAA at mail.gmail.com>
, Dridi Boukelmoune writes:
>On Fri, Jun 21, 2019 at 1:01 PM Poul-Henning Kamp <phk at phk.freebsd.dk> wrote:


>My point was rather that "all uses of STRING_LIST in the tree" aren't
>removed yet:
>
>    $ git grep STRING_LIST -- lib/libvmod_*
>    lib/libvmod_directors/vmod.vcc:$Method BACKEND .backend(STRING_LIST)
>    lib/libvmod_vtc/vmod.vcc:$Function VOID panic(STRING_LIST)

Hmm, I guess I should actually grep for STRING_LIST rather than
the functions operating on it :-)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

From dridi at varni.sh  Fri Jun 21 16:44:06 2019
From: dridi at varni.sh (Dridi Boukelmoune)
Date: Fri, 21 Jun 2019 16:44:06 +0000
Subject: STRING_LIST deorbit burn completed
In-Reply-To: <8184.1561127481@critter.freebsd.dk>
References: <62697.1561022935@critter.freebsd.dk>
 <CABoVN9DArXHiOJ2xaxGx-dqL1g2QhwQ9kaL6Lfa5y+LFVgs46Q@mail.gmail.com>
 <7692.1561122102@critter.freebsd.dk>
 <CABoVN9B+fkoTk9g0KfaqB4jt9bwhgHdKPRja468N79D_5FgnAA@mail.gmail.com>
 <8184.1561127481@critter.freebsd.dk>
Message-ID: <CABoVN9C9SCF4w6ohx2d+GOnj0FwgE1zOOrepRp+aa2o276yHxg@mail.gmail.com>

> Hmm, I guess I should actually grep for STRING_LIST rather than
> the functions operating on it :-)

I'm spoiled by git grep, it has so many killer features that I don't
see myself using anything other than git for source code :)

You can also grep in other branches without checking them out locally \o/

Dridi

From scan-admin at coverity.com  Thu Jun 27 02:30:31 2019
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Thu, 27 Jun 2019 02:30:31 +0000 (UTC)
Subject: Coverity Scan: Analysis failed for varnish
Message-ID: <5d142a46b741e_5ade2abb53ad4f4c73254@appnode-2.mail>

    Your request for analysis of varnish  is failed.
    Analysis status: Failure
    Please fix the error and upload the build again.

    Error details:
    ERROR: Coverity Build tool Version mismatch. Please download the latest Coverity Build tool from https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbe3z6lX4xngSV7AjAiTvG6_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQDcBU13-2BdJZ6IKGauCIxBfQxbtOrdqSX2HrJHOPnNTlG-2FuznRYNEa2JA5B-2BzS8HmdJfGvn1IOxGvZwQoX5OHEUizfYW1WCb1nFTm2WsQjy-2B0SGVjv0Nimdr-2B3SemCb1UYDdlQwCLrvaUk-2BuAiFb1eDNxEMwiTBJX3g-2FkrZiIZpocJ0KJAKe2FqczH-2Fl7FMBoL8-3D . Note that older versions of our tools may no longer be supported.
    For more detail explanation on the error, please check: https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2BukuZt9UUdRZhgmgzAKchwAzH1nH3073xDEXNRgHN6zzUI-2FRfbrE6mNOeeukHUQw-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQDcBU13-2BdJZ6IKGauCIxBfQxbtOrdqSX2HrJHOPnNTlGy2vPs1D62ToSZsO7C5un2IQzl5NXaPkmC-2B9dsfd6M4-2BR1Yoeq-2Fllw7O3UT5qjXqdq0xtf2b6qswQT8dtdJBm9vzgBRgvBBN-2BMO-2B3ad8WyFx2BecgEc-2Fm-2Fhee8IAPSCZv0WB0Y3dWeAqF906Hmj7C1E-3D

    If your build process isn't going smoothly, email us at scan-admin at coverity.com
    with your cov-int/build-log.txt file attached for assistance, or post your issue
    to the StackOverflow at https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2BukuZt9UUdRZhgmgzAKchwAzH1nH3073xDEXNRgHN6zzUI-2FRfbrE6mNOeeukHUQw-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQDcBU13-2BdJZ6IKGauCIxBfQxbtOrdqSX2HrJHOPnNTlG4fqZsMR1HIWTBk6tqhrI-2BtK0PdVnfDI8T8OmPPPpI5jgWCmmBM6R1MzO7m6UoQrKYzVWs5yBrOoal541dkD1AxAO6FE9vZx5cZirK2iRcWw1-2B81PECxtj33vSWH40obQfkMTBBnITc9a62a9Jj9Dog-3D

From scan-admin at coverity.com  Sun Jun 30 11:29:48 2019
From: scan-admin at coverity.com (scan-admin at coverity.com)
Date: Sun, 30 Jun 2019 11:29:48 +0000 (UTC)
Subject: Coverity Scan: Analysis completed for varnish
Message-ID: <5d189d2bee503_49c22aad6d350f584345a@appnode-2.mail>


    Your request for analysis of varnish has been completed successfully.
    The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQAeFqwMS3RrfA9NNt5PTq9PpmubDiLmxwiKB9AH4kRP-2FS4Q2C1qLo8fYoODjh0u-2F11XUfSs7s2p-2FbzVtK0ULjvDLT-2FXeHJsOm0uSEeifnhJoDYsGi6NRkgXtDiho8XXnFGQXDPaSZdIR6EDhpN28iTpLdBo13LlBLlOknu2qrqR354WgHO0TnN4g3Rs6LAsQCA-3D

    Build ID: 262633

    Analysis Summary:
       New defects found: 8
       Defects eliminated: 7

    If you have difficulty understanding any defects, email us at scan-admin at coverity.com,
    or post your question to StackOverflow
    at https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2BukuZt9UUdRZhgmgzAKchwAzH1nH3073xDEXNRgHN6zzUI-2FRfbrE6mNOeeukHUQw-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQAeFqwMS3RrfA9NNt5PTq9PpmubDiLmxwiKB9AH4kRP-2FRQKP3GOg-2Fw6ovn4JhFKt0w9J3DI340z01NIWTYJ6XB8N5WhI-2BQkCw4Kc3N7XPxokBx9Ml8hh1oqeX-2BpiGfJsZxxmVDaRLUqLEkR9Oe-2FKyKqvqiZ1v3pfNRBPdAaprDycSLvwuDrlnQCpAL9qHBMnxU-3D