VSB_quote has gotten messy

Poul-Henning Kamp phk at phk.freebsd.dk
Mon Apr 20 09:44:47 UTC 2020

I finally got around to look at VSB_QUOTE_GLOB feature Guillaume committed
by accident some time ago, and it doesn't work correctly as far as I
can tell, for instance, the difference between inputs:
makes no sense to me.

However, I can hardly blame Guillaume, because it is not very
consistent or clear how VSB_QUOTE is supposed to work in the first
place, I just spent 4 hours trying to find out, because we sort of
made it up as we went.

I propose that b0d1a40f326f... gets backed out before it has any
use in the tree, and put an errata on the 6.4 release page to the
effect of "do not use VSB_QUOTE_GLOB".

I also propose that we should deprecate VSB_quote*() in its current
form, ie: leave around for the benefit of VMODers for 7.x, remove
in 8.x.

Finally, I propose a new and more well thought, and better documented
replacement, VSB_encode(), to be added shortly.

Comments ?

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.

More information about the varnish-dev mailing list