From dridi at varni.sh Fri Dec 3 14:48:10 2021 From: dridi at varni.sh (Dridi Boukelmoune) Date: Fri, 3 Dec 2021 14:48:10 +0000 Subject: Making libunwind the default In-Reply-To: <17526.1599474526@critter.freebsd.dk> References: <17526.1599474526@critter.freebsd.dk> Message-ID: On Mon, Sep 7, 2020 at 10:28 AM Poul-Henning Kamp wrote: > > -------- > Dridi Boukelmoune writes: > > > After a brief discussion on IRC I agreed to provide comparative stack > > traces, I'll find some time to make a couple up. > > Status in FreeBSD-land: > > The libunwind backtrace does not look obviously superior, or for > that matter significantly different on FreeBSD. > > Libunwind does not seem to support 32-bit Arm well, at least on FreeBSD. > > Would it make sense to make this a packaging decision ? Quick followup to close this thread for now. It was already a packaging decision, but we changed the default from "no" to "auto". Having libunwind present at build time is enough to select it. https://github.com/varnishcache/varnish-cache/pull/3739 Cheers, Dridi From guillaume.quintard at gmail.com Mon Dec 27 02:11:50 2021 From: guillaume.quintard at gmail.com (Guillaume Quintard) Date: Sun, 26 Dec 2021 18:11:50 -0800 Subject: bo access from VFP Message-ID: Happy holidays to everyone, Unless I'm mistaken, there's no way for a VFP to access the busyobj, and was wondering if that could change as I need it to retrieve a vmod_priv. For some context, I stumbled on this while working on this vmod: https://github.com/gquintard/vmod_rers/tree/v0.0.2 (It's in rust, and I'm using it to explore what kind of bindings we need. I already have a couple of examples for VDP[1] and VFP[2] in the crate[3] repo, but of course they don't need as much as a real vmod.) With vmod_rers, the user is able to add regex/sub pairs on a per-request basis [4], and they will be acted upon by the VDP. To store and retrieve the pairs I use the regular "fake vrt_ctx trick"[4], since the VDP has access to the req struct, it's very easy to build. However, I'm unable to do the same thing on the VFP side since I have neither a req (fair) nor a bo. Is there a big reason for not having access to it, or is it just that nobody asked for it until now? Happy new year! [1]: https://github.com/gquintard/varnish-rs/tree/main/examples/vmod_vdp [2]: https://github.com/gquintard/varnish-rs/tree/main/examples/vmod_vfp [3]: https://crates.io/crates/varnish [4]: https://github.com/gquintard/vmod_rers/blob/v0.0.2/vmod.vcc#L47 [5]: https://github.com/gquintard/vmod_rers/blob/v0.0.2/src/lib.rs#L221 -- Guillaume Quintard -------------- next part -------------- An HTML attachment was scrubbed... URL: From guillaume.quintard at gmail.com Fri Dec 31 23:48:46 2021 From: guillaume.quintard at gmail.com (Guillaume Quintard) Date: Fri, 31 Dec 2021 15:48:46 -0800 Subject: bo access from VFP In-Reply-To: References: Message-ID: Small follow-up on that one: it would be nice for VFP to be able to disable streaming (bo->do_stream), so that's an extra argument to be able to access the busyobj -- Guillaume Quintard On Sun, Dec 26, 2021 at 6:11 PM Guillaume Quintard < guillaume.quintard at gmail.com> wrote: > Happy holidays to everyone, > > Unless I'm mistaken, there's no way for a VFP to access the busyobj, and > was wondering if that could change as I need it to retrieve a vmod_priv. > > For some context, I stumbled on this while working on this vmod: > https://github.com/gquintard/vmod_rers/tree/v0.0.2 > (It's in rust, and I'm using it to explore what kind of bindings we need. > I already have a couple of examples for VDP[1] and VFP[2] in the crate[3] > repo, but of course they don't need as much as a real vmod.) > > With vmod_rers, the user is able to add regex/sub pairs on a per-request > basis [4], and they will be acted upon by the VDP. To store and retrieve > the pairs I use the regular "fake vrt_ctx trick"[4], since the VDP has > access to the req struct, it's very easy to build. > However, I'm unable to do the same thing on the VFP side since I have > neither a req (fair) nor a bo. > > Is there a big reason for not having access to it, or is it just that > nobody asked for it until now? > > Happy new year! > > [1]: https://github.com/gquintard/varnish-rs/tree/main/examples/vmod_vdp > [2]: https://github.com/gquintard/varnish-rs/tree/main/examples/vmod_vfp > [3]: https://crates.io/crates/varnish > [4]: https://github.com/gquintard/vmod_rers/blob/v0.0.2/vmod.vcc#L47 > [5]: https://github.com/gquintard/vmod_rers/blob/v0.0.2/src/lib.rs#L221 > -- > Guillaume Quintard > -------------- next part -------------- An HTML attachment was scrubbed... URL: