SHA256 from file descriptor

Poul-Henning Kamp phk at phk.freebsd.dk
Wed May 22 06:18:24 UTC 2024


--------
Dridi Boukelmoune writes:
> On Tue, May 21, 2024 at 5:38=E2=80=AFPM Poul-Henning Kamp <phk at phk.freebsd.=
> dk> wrote:
> >
> > Dridi Boukelmoune writes:
> >
> > > Are we interested in that kind of change (see attached diff) or do we
> > > strictly stick to the original source that was bundled in libvarnish?
> >
> > What's the usecase ?
> >
> > If regular file:  Why not mmap and save the kernel/userland copies ?
>
> Because the code from which I extracted this function was doing a copy
> while computing the checksum on the fly, so I didn't consider mmap
> when I extracted the read part of the code.

But what is the use-case ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-dev mailing list