SHA256 from file descriptor

[Poul-Henning Kamp]

--------
Dridi Boukelmoune writes:

> > Yes, but what do we need that for ?
>
> We don't, I'm working in a VMOD that computes hashes of regular files
> among other things. This looked like generic code not specific to that
> VMOD.

Is it a VMOD you expect to be adopted into the tree, and if so, could
you say a bit more about it ?

If it is an out-of-tree VMOD, I'm not very keen on adding library
functions just for one VMOD (but can probably be persuaded if the
functions are tied to Varnish through data structures etc.)

This specific suggestion does not meet that threshold, and we would
also have to add an explicit test-case for gcov, so I really dont
see much benefit ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.